Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Order Deserialization Fails Outside Error Handling if LO File Deleted? #351

Open
effs opened this issue Feb 8, 2023 · 3 comments
Open
Labels
defect Something isn't working at all or correctly Load Order Stuffs related to LO implementation
Milestone

Comments

@effs
Copy link
Collaborator

effs commented Feb 8, 2023

Looks like ENOENT is somehow escaping the TaskEither.tryCatch, might be the Task instead of a Promise?

Screenshot 2023-02-08 at 5 14 51

@effs effs added defect Something isn't working at all or correctly Load Order Stuffs related to LO implementation labels Feb 8, 2023
@effs effs added this to the 0.9.8 milestone Feb 8, 2023
@effs
Copy link
Collaborator Author

effs commented Feb 11, 2023

Can't seem to reproduce this, the error is correctly caught for me. It seems unlikely that Steam or the C: would confound the issue..

Sat, 11 Feb 2023 03:13:36 GMT - warn: [cyberpunk2077] V2077 Load Order: Failed to deserialize load order, ignoring the file: Failed to read file G:\GOG\Cyberpunk 2077\V2077\Load Order\V2077-load-order-JoXXWgtZn.json (on disk G:\GOG\Cyberpunk 2077\V2077\Load Order\V2077-load-order-JoXXWgtZn.json): Error: ENOENT: no such file or directory, open 'G:\GOG\Cyberpunk 2077\V2077\Load Order\V2077-load-order-JoXXWgtZn.json'

@effs
Copy link
Collaborator Author

effs commented Feb 11, 2023

image

@effs effs changed the title Load Order Deserialization Fails Outside Error Handling if File Deleted Load Order Deserialization Fails Outside Error Handling if LO File Deleted? Feb 11, 2023
@effs effs added question Further information is requested Needs Additional Info Need answers/confirmation/further info from somebody labels Feb 11, 2023
@effs
Copy link
Collaborator Author

effs commented Feb 11, 2023

...Ok, makes sense.

  1. Vortex must be running
  2. One of the parent folders must be missing, not just the file
  3. The failure happens on write, read handles the error fine

So adding some generic protection around the file write as required by #346 will 'solve' this problem in that we can at least show a slightly better error message.

@effs effs removed question Further information is requested Needs Additional Info Need answers/confirmation/further info from somebody labels Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working at all or correctly Load Order Stuffs related to LO implementation
Projects
None yet
Development

No branches or pull requests

1 participant