Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-launcher is run from build/bin directory, not install bin directory #186

Open
jeff-cohere opened this issue Feb 11, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@jeff-cohere
Copy link
Contributor

When one uses EkatCreateUnitTest to create a unit test, EKAT uses a script called test-launcher to launch the test. However, EkatCreateUnitTest assumes that it can find test-launcher in the bin subdirectory of your build directory. This is only true if you're building EKAT with add_subdirectory. It will not work if you've installed EKAT somewhere already.

To Reproduce
Steps to reproduce the behavior:

  1. Build EKAT and install it somewhere
  2. Build your EKAT-dependent software, pointing it to the installed version of EKAT
  3. Try to run unit tests created using EkatCreateUnitTest. They will all fail because test-launcher can't be found.

Expected behavior
It would be nice to have EKAT install test-launcher in the bin subdirectory of its CMAKE_INSTALL_PREFIX.

@jeff-cohere jeff-cohere added the bug Something isn't working label Feb 11, 2022
@jeff-cohere
Copy link
Contributor Author

Hrmm, maybe never mind. Let me verify this.

@bartgol
Copy link
Contributor

bartgol commented Feb 11, 2022

I think this will become a non-issue, as soon as #179 is merged. I am holding off the merge, since I need to work on a PR that ensures the same capabilities are kept in scream.

@bartgol
Copy link
Contributor

bartgol commented Feb 11, 2022

Actually, coming to think of it, we might keep test-launcher in ekat. Just not add it by default to the command to be run by add_test. There's some logic in ekat_catch_main.cpp to handle the selection of the GPU, and test-launcher is already doing some of that work if the proper test properties have been set (and our EkatCreateUnitTest[xyz] do set them).

I will make a not to keep the test-launcher. In which case, if you verify this is indeed an issue, we should address it.

@jeff-cohere
Copy link
Contributor Author

Okay, sounds good. I think it might not actually be an issue after all, but I will verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants