Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make skip_t0_output true by default #3006

Open
mahf708 opened this issue Sep 19, 2024 · 5 comments
Open

make skip_t0_output true by default #3006

mahf708 opened this issue Sep 19, 2024 · 5 comments

Comments

@mahf708
Copy link
Contributor

mahf708 commented Sep 19, 2024

We currently special-case this to be true for ERS/ERP tests, but we really oughta make it true by default

@bartgol
Copy link
Contributor

bartgol commented Sep 19, 2024

This would have the side effect of changing the first output file name. E.g., if the run starts at 2000-01-01-00000, and output is INSTANT every 5 min, the first file will have timestamp 2000-01-01-00600. I assume that's acceptable?

@mahf708
Copy link
Contributor Author

mahf708 commented Sep 19, 2024

Yeah, that's fine. The "conventional" (e.g., EAM) behavior is exactly this:

if the run starts at 2000-01-01-00000, and output is INSTANT every 5 min, the first file will have timestamp 2000-01-01-00600

So, if someone wants something different, they should toggle the flag...

Do you remember if people specifically requested something different back in the day? We could probably review when support for this was added and see what the thinking was at the time?

@bartgol
Copy link
Contributor

bartgol commented Sep 19, 2024

Do you remember if people specifically requested something different back in the day? We could probably review when support for this was added and see what the thinking was at the time?

I don't think anybody requested anything different. I think that's always been the behavior. From a recent message (maybe on slack? by Rob maybe?) I found out EAM puts t0 output in its own file. In EAMxx, we just stuffed it in the same output as following instants. Maybe that generated some discrepancy and confusion.

As for the file name, users can also ask for 1 file per month (if that's not too big). We could even introduce "1 file per day", for high frequency output, if that helped. This would take away the annoyint "-00600" part from the filename.

@mahf708
Copy link
Contributor Author

mahf708 commented Sep 19, 2024

I found out EAM puts t0 output in its own file.

Hmmm. I don't think this is the default behavior... I've never seen it!

@bartgol
Copy link
Contributor

bartgol commented Sep 19, 2024

I thought Rob said something like that, but it's quite possible I misread/misinterpreted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants