-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global_time_series
plot parameters to the cfg
#399
Comments
@chengzhuzhang @BunnyVon @golaz @xylar You may have thoughts on the above; please let me know if so. |
Frankly, I think this may be infeasible. The global time series plots were created ad-hoc and not at all standardized (though I tried my best to do so in #389). They are thus difficult to generalize. I know E3SM Diags creates a large number of plot types for different variables, but my understanding is the plot structures are more or less standardized in a category. That said, looking at the lat-lon plots of https://web.lcrc.anl.gov/public/e3sm/zppy_test_resources/expected_complete_run/e3sm_diags/atm_monthly_180x360_aave/model_vs_obs_1850-1851/viewer/lat_lon/index.html I see the color bars differ between some of the plots; I suppose that would be an example of a structure change between plots. I may need to revisit how E3SM diags handles this -- @chengzhuzhang can you point me to the files where that is done, if possible? The colors aren't specified from the |
@chengzhuzhang did mention "For accommodating additional variables, I would suggest to create a striped down version of plot function that can work with any variables without customization." I suppose that option would entail picking a "standard" setting for all of the above parameters, letting users pass in a |
I got started on this option in #400 -- but there are still a number of obstacles to running successfully. See that pull request for further comments. |
#389 significantly streamlined the process to add plots. However, people wishing to add new plots will still need to create pull requests to edit
zppy/templates/coupled_global.py
; specifically they need to add their own specific plot function, such as the following, which gives values to each of the plot parameters.If further changes are needed, they'll have to edit the
plot
function itself. However, presumably in most cases new plots will only require setting the above parameters accordingly. That could be done with the configuration file.Note that it would significantly pollute the name space of
zppy/templates/default.ini
to include all these parameters in there. That said,e3sm_diags
similarly includes many parameters that get passed on to the actual E3SM Diags package, so it wouldn't be unprecedented.(I was thinking we could do something like #138 and have a
global_time_series
-specificcfg
but it looks like that would have the same problem of a user needing to merge changes into the repository).Complications:
global_time_series
, each setting these differently -- but then that would create 50 independent plots, not one PDF of all 50 plots. In the case of Add BGC global mean analysis #365, we're effectively talking about specifying 20*50=1,000 parameters.lambda
for"Var"
. The functions for"var"
differ signficantly between plots and cannot simply be automated. https://github.com/E3SM-Project/zppy/blob/main/zppy/templates/coupled_global.py currently has:global_time_series
now will make Make an independent package for Global Time Series #398 that much harder to implement -- and thus make it less likelyglobal_time_series
will ever be decoupled fromzppy
(perhaps that is not a major concern though).The text was updated successfully, but these errors were encountered: