Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for Andes #450

Open
forsyth2 opened this issue Jul 5, 2023 · 4 comments · May be fixed by #455
Open

Improve support for Andes #450

forsyth2 opened this issue Jul 5, 2023 · 4 comments · May be fixed by #455
Labels
semver: new feature New feature (will increment minor version)

Comments

@forsyth2
Copy link
Collaborator

forsyth2 commented Jul 5, 2023

Improve support for Andes

Automatically determine the account at https://github.com/E3SM-Project/zppy/blob/main/zppy/__main__.py#L143:

    if config["default"]["account"] == "":
        if default_account:
            config["default"]["account"] = default_account
        elif config["default"]["machine"] in ["compy", "pm-cpu", "pm-gpu", "chrysalis"]:
            config["default"]["account"] = "e3sm"
        elif config["default"]["machine"] == "anvil":
            config["default"]["account"] = "condo"
        else:
            raise ValueError(f"Invalid machine {config['default']['machine']}")

Add the following to https://github.com/E3SM-Project/zppy/blob/main/zppy/templates/slurm_header.sh (from @whannah1):

{% elif machine == 'andes' %}

# Running on andes

#SBATCH  --job-name={{ prefix }}
#SBATCH  --account={{ account }}
#SBATCH  --nodes={{ nodes }}
#SBATCH  --output={{ scriptDir }}/{{ prefix }}.o%j
#SBATCH  --exclusive
#SBATCH  --time={{ walltime }}
#SBATCH  --partition={{ partition }}

[Lines already existing in the file won't need to be duplicated]
@forsyth2 forsyth2 added the semver: new feature New feature (will increment minor version) label Jul 5, 2023
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jul 5, 2023

Note that https://github.com/E3SM-Project/mache/blob/main/mache/machines/andes.cfg has no web_portal section.

@xylar
Copy link
Contributor

xylar commented Jul 5, 2023

Note that https://github.com/E3SM-Project/mache/blob/main/mache/machines/andes.cfg has no web_portal section

Some machines don't have a web portal, so there's no web_portal section. I thought that was the case for Andes but if there is a web portal that I don't know about, please let me know so I can add it.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jul 5, 2023

@xylar I'm not sure if there is a web portal, but I wanted to note the issue here. @whannah1 found that zppy will fail because of the missing web portal. The best solution might be to have some sort of skip-web option/parameter.

@xylar
Copy link
Contributor

xylar commented Jul 5, 2023

Yes, something like that sounds necessary in the case of Andes. I looked around and Im' pretty sure there's not a web portal visible to the public at OLCF.

@forsyth2 forsyth2 linked a pull request Jul 13, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver: new feature New feature (will increment minor version)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Andes support E3SM-Project/zppy
2 participants
@xylar @forsyth2