Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional links to a term page based on Bioregistry providers #601

Open
cthoyt opened this issue Nov 29, 2023 · 7 comments
Open

Add additional links to a term page based on Bioregistry providers #601

cthoyt opened this issue Nov 29, 2023 · 7 comments

Comments

@cthoyt
Copy link
Contributor

cthoyt commented Nov 29, 2023

Here's the OLS page for the Cell Ontology's term for osteoblast (CL:0000062).

The Bioregistry has multiple "providers" for the Cell Ontology. This means that it has URL formats that go to third party websites that has some information about them. One such site is Cell Guide, which has the following page for osteoblast: https://cellxgene.cziscience.com/cellguide/CL_0000062

Given the OLS is consuming the Bioregistry's data, you can get the following information for each provider while you parse it:

  1. a provider code cellguide
  2. a human-readable title Cell Guide
  3. a description
  4. a homepage
  5. a URI format string https://cellxgene.cziscience.com/cellguide/CL_$1,

@dosumis asked in biopragmatics/bioregistry#1001 if it would be possible to configure showing a Cell Guide link on the OLS term page for osteoblast (and same for every other CL term page)

@dosumis
Copy link

dosumis commented Nov 29, 2023

This looks very generally useful to me. I'm keen to take advantage for multiple projects/ontologies.

Open questions:

  • Should we support configuration of this - ontology providers optionally (?) get to choose which linkouts are used.
  • Should linkout section have a disclaimer about versions? (linked site may not be using same version as displayed on OLS - this may cause confusion)

@dosumis
Copy link

dosumis commented Nov 29, 2023

CC @udp

@jamesamcl
Copy link
Member

I chatted with @dosumis about this over lunch and he said that not every combination of URI format/ID would produce a valid link. I am not sure the OLS dataload should be annotating with URLs which do not resolve.

I suppose the ontology providers choosing the linkouts would work, but then why would they not add an URL xref directly to the term in the OWL?

@cthoyt
Copy link
Contributor Author

cthoyt commented Dec 4, 2023

@udp you're right, the two solutions are either make the link for everything, or enumerate which ones the link should get made for. Doing this directly in the ontology is one possibility. However, a database cross-reference is not the appropriate way to handle this since dbxrefs should be used to refer to semantic spaces. Maybe a seeAlso property would be good?

@dosumis
Copy link

dosumis commented Dec 4, 2023

I've spent the past few years discouraging full URLs in xrefs as an extra burden on ontology users - who need to distinguish CURIE prefixes from protocol prefixes when parsing. But I'm willing to live with that if we can get a standard for annotating full URLs in xrefs with link text (and ideally also a link to a logo).

@dosumis
Copy link

dosumis commented Dec 4, 2023

Just saw Charlie's comment. seeAlso is good for me. The same points around annotating the axioms apply.

@jamesamcl
Copy link
Member

I've spent the past few years discouraging full URLs in xrefs as an extra burden on ontology users - who need to distinguish CURIE prefixes from protocol prefixes when parsing. But I'm willing to live with that if we can get a standard for annotating full URLs in xrefs with link text (and ideally also a link to a logo).

Isn’t the datatype of a URL different from that of a string literal (curie) - or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants