Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiFabRegister: replace has with has_vector for vectors #5305

Open
EZoni opened this issue Sep 23, 2024 · 0 comments
Open

MultiFabRegister: replace has with has_vector for vectors #5305

EZoni opened this issue Sep 23, 2024 · 0 comments
Assignees
@EZoni
Labels
cleaning Clean code, improve readability

Comments

@EZoni
Copy link
Member

EZoni commented Sep 23, 2024

Originally posted in #5230 (comment).

As a follow-up on #5230, we should replace has with has_vector wherever possible, so in most occurrences where has is called to check if a vector field exists in the register, unless we intentionally want to check only a single specific direction.
@EZoni EZoni added the cleaning Clean code, improve readability label Sep 23, 2024
@EZoni EZoni self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EZoni EZoni

Labels
cleaning Clean code, improve readability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EZoni