From b16dc0a1cc01e054f27940d10a9a038399fc1478 Mon Sep 17 00:00:00 2001 From: Richard Top Date: Mon, 15 Jan 2024 12:47:09 +0000 Subject: [PATCH 1/5] {2023.06}[gompi/2023b] netCDF v4.9.2 --- .../software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml b/easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml index b184b88701..9a3b8efa6d 100644 --- a/easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml +++ b/easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml @@ -2,3 +2,6 @@ easyconfigs: - GCC-13.2.0.eb - foss-2023b.eb - SciPy-bundle-2023.11-gfbf-2023b.eb + - netCDF-4.9.2-gompi-2023b.eb: + options: + from-pr: 19534 From 15c228b555590b0da28d174ce79d1a8cea44c64b Mon Sep 17 00:00:00 2001 From: Richard Top Date: Tue, 16 Jan 2024 08:53:33 +0000 Subject: [PATCH 2/5] added a hook for neoverse_v1 failing tests --- eb_hooks.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/eb_hooks.py b/eb_hooks.py index 7c52e24ff1..41d196b097 100644 --- a/eb_hooks.py +++ b/eb_hooks.py @@ -378,6 +378,18 @@ def pre_test_hook_ignore_failing_tests_SciPybundle(self, *args, **kwargs): if self.name == 'SciPy-bundle' and self.version in scipy_bundle_versions and cpu_target == CPU_TARGET_NEOVERSE_V1: self.cfg['testopts'] = "|| echo ignoring failing tests" +def pre_test_hook_ignore_failing_tests_netCDF(self, *args, **kwargs): + """ + Pre-test hook for SciPy-bundle: skip failing tests for selected netCDF versions on neoverse_v1 + cfr. https://github.com/EESSI/software-layer/issues/425 + The following tests are problematic: + 163 - nc_test4_run_par_test (Timeout) + 190 - h5_test_run_par_tests (Timeout) + A few other tests are skipped in the easyconfig and patches for similar issues, see above issue for details. + """ + cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR') + if self.name == 'netCDF' and self.version == '4.9.2' and cpu_target == CPU_TARGET_NEOVERSE_V1: + self.cfg['testopts'] = "|| echo ignoring failing tests" def pre_single_extension_hook(ext, *args, **kwargs): """Main pre-extension: trigger custom functions based on software name.""" @@ -557,6 +569,7 @@ def inject_gpu_property(ec): 'ESPResSo': pre_test_hook_ignore_failing_tests_ESPResSo, 'FFTW.MPI': pre_test_hook_ignore_failing_tests_FFTWMPI, 'SciPy-bundle': pre_test_hook_ignore_failing_tests_SciPybundle, + 'netCDF': pre_test_hook_ignore_failing_tests_netCDF, } PRE_SINGLE_EXTENSION_HOOKS = { From 90e25455b6e1525165d42425ee6035825d040aec Mon Sep 17 00:00:00 2001 From: Richard Top Date: Tue, 16 Jan 2024 12:26:37 +0000 Subject: [PATCH 3/5] added eessi-2023.06-known-issues.yml --- eessi-2023.06-known-issues.yml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 eessi-2023.06-known-issues.yml diff --git a/eessi-2023.06-known-issues.yml b/eessi-2023.06-known-issues.yml new file mode 100644 index 0000000000..cb2d945af2 --- /dev/null +++ b/eessi-2023.06-known-issues.yml @@ -0,0 +1,4 @@ +- aarch64/neoverse_v1: + - netCDF-4.9.2-GCC-12.3.0/GCC-13.2.0: + - issue: https://github.com/EESSI/software-layer/issues/425 + - info: "netCDF intermittent test failures" From 9944ab6546d856acdf0d92231dac56af8aab82b8 Mon Sep 17 00:00:00 2001 From: TopRichard <121792457+TopRichard@users.noreply.github.com> Date: Tue, 16 Jan 2024 17:17:29 +0100 Subject: [PATCH 4/5] Update eb_hooks.py Co-authored-by: ocaisa --- eb_hooks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eb_hooks.py b/eb_hooks.py index 41d196b097..3b18f330ed 100644 --- a/eb_hooks.py +++ b/eb_hooks.py @@ -380,7 +380,7 @@ def pre_test_hook_ignore_failing_tests_SciPybundle(self, *args, **kwargs): def pre_test_hook_ignore_failing_tests_netCDF(self, *args, **kwargs): """ - Pre-test hook for SciPy-bundle: skip failing tests for selected netCDF versions on neoverse_v1 + Pre-test hook for netCDF: skip failing tests for selected netCDF versions on neoverse_v1 cfr. https://github.com/EESSI/software-layer/issues/425 The following tests are problematic: 163 - nc_test4_run_par_test (Timeout) From 34f4c453044ea6acd324b462f47de38db33c3b61 Mon Sep 17 00:00:00 2001 From: Kenneth Hoste Date: Thu, 18 Jan 2024 12:03:25 +0100 Subject: [PATCH 5/5] fix known issues YAML file for netCDF --- eessi-2023.06-known-issues.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/eessi-2023.06-known-issues.yml b/eessi-2023.06-known-issues.yml index cb2d945af2..0ee661be73 100644 --- a/eessi-2023.06-known-issues.yml +++ b/eessi-2023.06-known-issues.yml @@ -1,4 +1,7 @@ - aarch64/neoverse_v1: - - netCDF-4.9.2-GCC-12.3.0/GCC-13.2.0: + - netCDF-4.9.2-gompi-2023a.eb: + - issue: https://github.com/EESSI/software-layer/issues/425 + - info: "netCDF intermittent test failures" + - netCDF-4.9.2-gompi-2023b.eb: - issue: https://github.com/EESSI/software-layer/issues/425 - info: "netCDF intermittent test failures"