Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads sometimes fail to complete fully #185

Open
android-t709 opened this issue Aug 13, 2024 · 0 comments
Open

Downloads sometimes fail to complete fully #185

android-t709 opened this issue Aug 13, 2024 · 0 comments

Comments

@android-t709
Copy link

I'm not sure if I should put this here or in https://github.com/EFForg/rs-google-play.
Sometimes, downloads fail to complete. For example:

Downloading com.instagram.android...
[00:00:11] ████████████████░░░░░░░░░░░░░░░░░░░░░░░░ 31.95 MiB/75.64 MiB | com.instagram.android.apk
An error has occurred attempting to download com.instagram.android. Retry #1...
error details: request or response body error: error reading a body from connection: end of file before message length reached

(I added mp_log.println(format!("error details: {}", err)).unwrap(); in src/google_play.rs)

By default, it tries to download again, but will fail, because the file already exists.

I tried using a (poorly) modified version of https://github.com/EFForg/rs-google-play/blob/master/gpapi/src/lib.rs to account for the length of the file and delete if the download doesn't match the expected length. Sleeping and retrying works quite well here, but this doesn't handle split apks well. (Should redownloads of failed files be handled by apkeep, or by gpapi?)

I couldn't figure out how to use something like reqwest_resume to resume dropped connections.

My primary use case is trying to reliably bulk-download apks from a list. (apkeep -r 1 still has intermittent issues at the start of a download, and most downloads fail ~100 apps in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant