Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded values always 100 for some analyses #41

Open
MaximMoinat opened this issue Feb 16, 2022 · 1 comment · Fixed by #42
Open

Rounded values always 100 for some analyses #41

MaximMoinat opened this issue Feb 16, 2022 · 1 comment · Fixed by #42
Labels
bug Something isn't working

Comments

@MaximMoinat
Copy link

MaximMoinat commented Feb 16, 2022

There are unintended calls to count_big of an already summed total in analyses queries that also calculate a numerical distribution. This issue was found in 25 analyses.
E.g. analysis 406:

floor((count_big(o.total)+99)/100)*100 as count_value,

count_big(int) will always return 1, which rounds up to 100. (due to some quirks, I have also sometimes seen values of 200)

The equivalent Achilles analysis query does not contain a count at this level.

@MaximMoinat MaximMoinat added the bug Something isn't working label Feb 16, 2022
@MaximMoinat
Copy link
Author

Proposed fix: remove count_big of a total.

MaximMoinat pushed a commit that referenced this issue Feb 16, 2022
This was referenced Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant