Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseActionWatcher.watch should provide a way to handle error #181

Open
tiendq opened this issue Jan 2, 2020 · 1 comment
Open

BaseActionWatcher.watch should provide a way to handle error #181

tiendq opened this issue Jan 2, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tiendq
Copy link

tiendq commented Jan 2, 2020

Currently method BaseActionWatcher.watch catches errors in an internal try/catch block and silently swallow the errors. It stops watching on any error without providing any chance to retry. It returns undefined in all cases :O, and all state properties are private so there's no way to handle errors from derived classes.

@jeffreyssmith2nd jeffreyssmith2nd added the enhancement New feature or request label Jan 2, 2020
@tiendq
Copy link
Author

tiendq commented Jan 3, 2020

It should be a class design bug, not an enhancement. Because whenever a network error happens for example, client app (which using demux) knows nothing and can do nothing even if it wants to restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants