Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reading Fixed format MPS files #1860

Closed
rolfvdhulst opened this issue Jul 29, 2024 · 2 comments
Closed

Error reading Fixed format MPS files #1860

rolfvdhulst opened this issue Jul 29, 2024 · 2 comments
Assignees

Comments

@rolfvdhulst
Copy link

rolfvdhulst commented Jul 29, 2024

Highs currently fails to read the MIPLIB 2017 collection instance "rvb-sub".
The issue appears to be that the free format incorrectly classifies the file as not fixable, even though the fixed format mps reader can read it just fine. In particular, the MPS file starts with:

NAME          rvb-sub
ROWS
 E  s0        $t5                  0

but the last line is incorrectly classified as not being interpretable in fixed format by the free format reader.

I will submit a PR that fixes this soon.

@jajhall
Copy link
Sponsor Member

jajhall commented Sep 7, 2024

Interesting: the problem here is that the file has comments at the end of non-comment lines. I've never seen this feature in an MPS file.

It's possible that this will be done for a free format MPS file, so I can't accept your fix.

The correct fix is to ignore any characters after a $ sign

@jajhall jajhall mentioned this issue Sep 12, 2024
@jajhall
Copy link
Sponsor Member

jajhall commented Sep 12, 2024

Closed by #1920

@jajhall jajhall closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants