Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit-testers for FORTRAN code in CMEPS #458

Open
ekluzek opened this issue May 17, 2024 · 3 comments
Open

Add unit-testers for FORTRAN code in CMEPS #458

ekluzek opened this issue May 17, 2024 · 3 comments
Labels
CESM only enhancement New feature or request

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented May 17, 2024

In #429 I added new code and a unit-tester for it under the CTSM PR that uses it. I'm wondering if unit-testers is something that should be added to CMEPS? Initially maybe the way to go would be to have the unit-tester in CMEPS, but still use the CTSM infrastructure to build and run it?

@billsacks thoughts on this?

@ekluzek ekluzek added enhancement New feature or request CESM only labels May 17, 2024
@billsacks
Copy link
Member

I very much support the addition of unit tests where appropriate.

Currently there is some unit test infrastructure in CIME that drives the share code unit tests and used to drive the cpl7 unit tests... so it could make sense to integrate the driving of CMEPS into there.

@ekluzek ekluzek changed the title Add unit-testers for FORTRAN code in CMEPS? Add unit-testers for FORTRAN code in CMEPS May 21, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented May 21, 2024

OK, sounds good.

In #429 I propose that I create a new test subdirectory under cesm/nuopc_cap_share and move the unit-tester I put under CTSM to there:

https://github.com/ESCOMP/CTSM/pull/2545/files#diff-d420afd07928ac2d86f444cd1a8d08a3161f479361f328f9b1db324059136ec1

For the CTSM PR I'll still build it as one of the CTSM unit-tests. I think this change will be easy for me to make.

In the future as you point out it would be good to have the infrastructure in CMEPS to run unit tests there. But, I'll let someone else figure that out and get it working.

How does that sound as a plan @billsacks?

@billsacks
Copy link
Member

That sounds fine - thanks @ekluzek .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CESM only enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants