Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMORized NOAA Global Monitoring Lab surface flask concentration measurements of trace gases (CH4, CO2, N2O) #3839

Open
jlenh opened this issue Dec 9, 2024 · 4 comments · May be fixed by #3847

Comments

@jlenh
Copy link

jlenh commented Dec 9, 2024

Issue #3838 offers to include a diagnostic for the climatology of surface concentrations of trace gases (CH4, CO2, N2O). In order to implement and test the diagnostic, the surface flask observations from NOAA's Global Monitoring Lab need to be cmorized and added to ESMValTool observational datasets (Tier 2).

The work done in this issue will implement a downloader and a formatter for the station surface concentrations of CO2, CH4 and N2O for #3838.

Parts of the cmorization of the datasets rely on code developed in #3227 since the modality and structure of the datasets are similar. A common formatting framework is developed for all three trace gases using an attribute in the dataset recipe to call a general formatting function to maximise the use of common functions.

Branch and pull request
Work ongoing by jlenh (me), current branch state in branch noaa_gml_surface_flask_trace_gases_cmorizer (not pushed yet, problems with access rights as contributor?)

@bettina-gier
Copy link
Contributor

For NOAA CO2 surface flasks we have the downloader and formatter scripts called 'ESRL' - Are these based on the data and what's the difference in format between these two cmorizers? If your cmorizer is more flexible as it's also used for more variables than that old one we could consider deprecating the 'ESRL' one.

@jlenh
Copy link
Author

jlenh commented Jan 7, 2025

For NOAA CO2 surface flasks we have the downloader and formatter scripts called 'ESRL' - Are these based on the data and what's the difference in format between these two cmorizers? If your cmorizer is more flexible as it's also used for more variables than that old one we could consider deprecating the 'ESRL' one.

Good catch, thanks! Hmm as far as I can tell they seem to be dealing with similar datasets (surface station data) and the 'ESRL' implementation seems to encompass broader modalities. I think it might be better then to slightly adapt the existing code if needed (spotted at least that the default file paths to download are for CO2) before adding a new suite of scripts.
I will have a look and do some tests!

@jlenh
Copy link
Author

jlenh commented Jan 9, 2025

@bettina-gier would you have a recommended way to use the formatter script for ESRL since the downloading of the station data is handled jointly in the script? Or like a simple recipe outline to test? I am yet not fully familiar with the processing when it is structured like this..

@bettina-gier
Copy link
Contributor

It's an old cmorizier before we did some restructuring, so it would be better to separate the downloading and formatting indeed. But if you have the raw data it should skip the downloading step. For checking, it's included in the recipes/examples/recipe_check_obs.yml l351ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants