Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose ports of internal services #13

Open
defnull opened this issue Jan 22, 2021 · 2 comments
Open

Do not expose ports of internal services #13

defnull opened this issue Jan 22, 2021 · 2 comments

Comments

@defnull
Copy link

defnull commented Jan 22, 2021

The current docker-compose file exposes all internal service ports (including redis and elasticsearch, which both are not even password protected) to the world for no reason at all.

@hjhsalo
Copy link
Member

hjhsalo commented Feb 9, 2021

Thanks for opening an issue about this.
Ports were opened for local development use case, but this is not mentioned in the README or anywhere else for that matter.
WDYT should we create a docker-compose-dev.yml that has ports mappings as they are now and remove port mappings other than 80 and 443 from docker-compose.yml ? (@hevp)
Also README.md should be updated accordingly.

@defnull
Copy link
Author

defnull commented Feb 9, 2021

Even for development this should be limited to localhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants