Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate compilation of shared MPAS infrastructure #40

Open
gdicker1 opened this issue Apr 2, 2024 · 0 comments
Open

Duplicate compilation of shared MPAS infrastructure #40

gdicker1 opened this issue Apr 2, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request external Has to do with externals

Comments

@gdicker1
Copy link
Contributor

gdicker1 commented Apr 2, 2024

In EarthWorks compsets with multiple MPAS cores ("FullyCoupled" or any case with MPAS-A dycore plus MPAS-SI prescribed mode), each MPAS core compiles its own copy of the shared MPAS infrastructure and links against that. This leads to inefficient use of build-time and lead to "Multiple defintion" errors during the final linking step (that were seen in #36).

This issue serves as reminder (mainly to me) to fix this in the build so that only one copy of the shared MPAS infrastructure is built per case.

(NOTE: "shared MPAS infrastructure" refers to the code that is not core-specific in MPAS. Essentially the contents of the src directory in the EarthWorksOrg/mpas-framework repo.)

@gdicker1 gdicker1 added the enhancement New feature or request label Apr 2, 2024
@gdicker1 gdicker1 self-assigned this Apr 2, 2024
@gdicker1 gdicker1 added the external Has to do with externals label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external Has to do with externals
Projects
None yet
Development

No branches or pull requests

1 participant