Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty URLs and selected menu item #6598

Open
a-r-m-i-n opened this issue Nov 28, 2024 · 4 comments
Open

Pretty URLs and selected menu item #6598

a-r-m-i-n opened this issue Nov 28, 2024 · 4 comments

Comments

@a-r-m-i-n
Copy link
Contributor

a-r-m-i-n commented Nov 28, 2024

Describe the bug
I've experienced two bug regarding selected menu items and pretty urls:

  1. The dashboard menu item (added by yield MenuItem::linkToDashboard('Dashboard', 'fa fa-home');) is not selected, when active. Same issue when using yield MenuItem::linkToUrl('Dashboard', 'fa fa-home', '/'); to register the menu item. The index action in dashboard controller got the #[Route('/', name: 'dashboard')] attribute set.
  2. When I'm in index action of any crud controller and append any querystring (e.g. ?filters or ?whatever) the first item in menu gets active (it doesn't matter if the first item is a dashboard or CRUD link).

To Reproduce
Tested with version 4.17.

(OPTIONAL) Additional context
The dashboard route has no routeCreatedByEasyAdmin attribute set.

@pfpro
Copy link
Contributor

pfpro commented Nov 28, 2024

same here

@ben29
Copy link

ben29 commented Nov 28, 2024

#6580

@dschoschu
Copy link

+1

1 similar comment
@jacobsenj
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants