Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard route is now relative. It's not checking the flag if relative URLs are desired #6614

Open
ServerExe opened this issue Dec 3, 2024 · 1 comment

Comments

@ServerExe
Copy link

ServerExe commented Dec 3, 2024

Describe the bug
Before this change: eaa6a5b#diff-0fc43e6aa310600bfb6252c7d2acd1150843aa4145bae8d24a0c8a0647570092R275 Dashboard URLs (or "pretty" urls) have been absolute. Now, they are relative (/admin). This is causing a "breaking change" in our company for our use cases.

Issue is that the mentioned code line above does not check the $urlType as you do a few lines below:
eaa6a5b#diff-0fc43e6aa310600bfb6252c7d2acd1150843aa4145bae8d24a0c8a0647570092R280

Besides of that there is a crud configuration method called ->generateRelativeUrls() in dashboards which we are not using. So, the current situation is a bit contradicting this flag by still using a relative url (which is using the default Symfony ABSOLUTE_PATH flag).

@ServerExe ServerExe changed the title Dashboard route is now relative. It's not checking the flag if relative URLs want to be used or not Dashboard route is now relative. It's not checking the flag if relative URLs are desired Dec 3, 2024
@ServerExe
Copy link
Author

ServerExe commented Dec 11, 2024

As a workaround this can be done in Dashboard controllers but this is not our desired solution:

Instead of this:

yield MenuItem::linkToDashboard('Dashboard', 'fa fa-home');

You can do this:

yield MenuItem::linkToRoute('Dashboard', 'fa fa-home', 'your_admin_route');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant