From 5d3318eb9db8daa346229a7d45266a14a11a9590 Mon Sep 17 00:00:00 2001 From: jchen293 Date: Wed, 10 Jul 2024 17:12:39 -0400 Subject: [PATCH] rename UPS_OAUTH_CARRIER_ACCOUNT_TYPES --- src/main/java/com/easypost/Constants.java | 2 +- .../java/com/easypost/service/CarrierAccountService.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/easypost/Constants.java b/src/main/java/com/easypost/Constants.java index cbc6bb83..c470d63b 100644 --- a/src/main/java/com/easypost/Constants.java +++ b/src/main/java/com/easypost/Constants.java @@ -66,7 +66,7 @@ public abstract static class CarrierAccountTypes { } public abstract static class UpsAccountTypes { - public static final List CARRIER_TYPES_WITH_CUSTOM_WORKFLOW = ImmutableList.of("UpsAccount", + public static final List UPS_OAUTH_CARRIER_ACCOUNT_TYPES = ImmutableList.of("UpsAccount", "UpsMailInnovationsAccount", "UpsSurepostAccount"); } diff --git a/src/main/java/com/easypost/service/CarrierAccountService.java b/src/main/java/com/easypost/service/CarrierAccountService.java index d888ae15..b40e8ea6 100644 --- a/src/main/java/com/easypost/service/CarrierAccountService.java +++ b/src/main/java/com/easypost/service/CarrierAccountService.java @@ -93,7 +93,7 @@ public CarrierAccount update(String id, final Map params) throws Map wrappedParams = new HashMap(); wrappedParams.put(selectTopLayerKey(type), params); - String endpoint = (Constants.UpsAccountTypes.CARRIER_TYPES_WITH_CUSTOM_WORKFLOW.contains(type) + String endpoint = (Constants.UpsAccountTypes.UPS_OAUTH_CARRIER_ACCOUNT_TYPES.contains(type) ? "ups_oauth_registrations/" : "carrier_accounts/") + id; @@ -123,7 +123,7 @@ public void delete(String id) throws EasyPostException { private static String selectCarrierAccountCreationEndpoint(final String carrierAccountType) { if (Constants.CarrierAccountTypes.CARRIER_TYPES_WITH_CUSTOM_WORKFLOW.contains(carrierAccountType)) { return "carrier_accounts/register"; - } else if (Constants.UpsAccountTypes.CARRIER_TYPES_WITH_CUSTOM_WORKFLOW.contains(carrierAccountType)) { + } else if (Constants.UpsAccountTypes.UPS_OAUTH_CARRIER_ACCOUNT_TYPES.contains(carrierAccountType)) { return "ups_oauth_registrations"; } else { return "carrier_accounts"; @@ -143,7 +143,7 @@ private static String selectTopLayerKey(final String carrierAccountType) throws String.format(Constants.ErrorMessages.MISSING_REQUIRED_PARAMETER, "carrier account type")); } - return Constants.UpsAccountTypes.CARRIER_TYPES_WITH_CUSTOM_WORKFLOW.contains(carrierAccountType) + return Constants.UpsAccountTypes.UPS_OAUTH_CARRIER_ACCOUNT_TYPES.contains(carrierAccountType) ? "ups_oauth_registrations" : "carrier_account"; }