Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially implement 0x swap plugins #329

Closed
wants to merge 2 commits into from
Closed

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented Jun 14, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@samholmes samholmes force-pushed the sam/0x-gasless-swap branch 2 times, most recently from eab9a8b to 903cc97 Compare June 14, 2024 21:03
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes needed here.

src/index.ts Outdated Show resolved Hide resolved
src/swap/defi/0x/0xSwap.ts Outdated Show resolved Hide resolved
src/swap/defi/0x/0xSwap.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/swap/defi/0x/0xGaslessSwap.ts Outdated Show resolved Hide resolved
src/swap/defi/0x/0xGaslessSwap.ts Outdated Show resolved Hide resolved
@samholmes samholmes force-pushed the sam/0x-gasless-swap branch from 903cc97 to 548fa0b Compare June 25, 2024 19:46
@samholmes samholmes force-pushed the sam/0x-gasless-swap branch from 548fa0b to a28e040 Compare June 25, 2024 21:39
@samholmes
Copy link
Contributor Author

Closed in favor of the final PR: #334

@samholmes samholmes closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants