Implement 0x gasless swap approve method #331
Conversation
samholmes
force-pushed
the
sam/0x-gassless-swap-approve
branch
2 times, most recently
from
26bf47c
to
9e0b084
Compare
src/swap/defi/0x/0xGaslessSwap.ts
Outdated
| // Some values may be updated later when the transaction is | ||
| // updated from queries to the network. | ||
| const transaction: EdgeTransaction = { | ||
| txid: apiSwapStatus.transactions[0].hash.slice(2), // Remove '0x' |
There was a problem hiding this comment.
I'd prefer .replace('0x', '') instead of .slice(2), in case they ever change their format. Also, can we alphabetize this section?
There was a problem hiding this comment.
Oh, I see the slice is moot now. Still, sorting might be nice.
src/swap/defi/0x/0xGaslessSwap.ts
Outdated
| const transaction: EdgeTransaction = { | ||
| txid: apiSwapStatus.transactions[0].hash.slice(2), // Remove '0x' | ||
| date: Date.now(), | ||
| currencyCode: fromCurrencyCode, |
There was a problem hiding this comment.
Interesting. This whole repo is using edge-core-js v2, whereas in the new core the currencyCode has been replaced with tokenId in all cases. That's why the network fee needed a currencyCode in the previous commits.
We don't need to do anything here, since upgrading the core is independent of adding this plugin, but it's something to keep in mind for the future. We may want to schedule a core upgrade in the near-ish future so future plugins can be cleaner.
samholmes
force-pushed
the
sam/0x-gassless-swap-approve
branch
from
9e0b084
to
367ebe7
Compare
|
Closed in favor of the final PR: #334 |
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none