Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion: Crashes when editing model #5619

Closed
1 task done
pfeerick opened this issue Oct 17, 2024 · 1 comment · Fixed by #5620
Closed
1 task done

Companion: Crashes when editing model #5619

pfeerick opened this issue Oct 17, 2024 · 1 comment · Fixed by #5620
Labels
bug/regression ↩️ A new version of EdgeTX broke something companion Related to the companion software

Comments

@pfeerick
Copy link
Member

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

When testing recent PRs, Companion crashed when trying to edit a model. It has happened with several PRs now, on both Windows and Linux, and I have only been able to reproduce this with a profile configured for the RM Pocket - other targets appear to be fine. First encounted it when trying to read from radio, but also happens with a "blank" model config.

Expected Behavior

For Companion to not crash when attempting to edit a model 😲 Looks like I was unlucky pulling the Pocket out as the test subject today 🤣

Steps To Reproduce

  1. Create a new profile for RadioMaster Pocket
  2. Create a new document
  3. Crete a new model - I skip the wizard and just use an empty one.
  4. Attempt to edit the newly created model - double click, via the toolbar, or pressing Enter.
  5. Companion will crash 'n burn

Version

Nightly (Please give date/commit below)

Transmitter

RadioMaster Pocket

Operating System (OS)

Linux, Windows

OS Version

Windows 11 24H2, Linux Mint 22

Anything else?

#5418 biuld (Aug 13th #f44221c9) didn't
#5317 build (Aug 29th #4ad4ef95) didn't
#5497 build (Sept 12th #3b7d7bf9) crashed (?!)
#5381 build (Sept 19th #e38edf3e) didn't

Maybe that gives some idea were it stems from...

@pfeerick pfeerick added companion Related to the companion software bug/regression ↩️ A new version of EdgeTX broke something labels Oct 17, 2024
@elecpower
Copy link
Collaborator

elecpower commented Oct 17, 2024

Debug confirms subscript out of bounds. Not confined to RM Pocket.

@elecpower elecpower changed the title Companion: Crashes when editing RM Pocket model Companion: Crashes when editing model Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something companion Related to the companion software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants