-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting rid of Textgrid #467
base: develop
Are you sure you want to change the base?
Conversation
My take on that would be a little bit different. I actually like the concept of a dedicated Additionally, the standard |
You are right. Was also thinking of keeping it but thought it would look a little sad with just a return of "doc". But with correct Error handling it gets relevant again. |
I reverted the unwanted changes and got only rid of the textgrid part in the wrapper function. @peterstadler what would be a good way of error handling here? The calls of the function expect a document, so shouldn't "doc()" fail when it can't parse? |
This reverts commit a3ee82a.
e8580b4
to
81e757e
Compare
It's a little bit beyond the scope of #322 but I couldn't resist to provide my take on a canonical function (including tests) for loading documents within the Edirom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested briefly with the clarinet quintet and all seemed to work
Description, Context and related Issue
#322
How Has This Been Tested?
Tested with the EditionExample.
Types of changes
Overview