Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/enhancements for ShOpt runs #5

Open
3 of 5 tasks
mcclearyj opened this issue Aug 17, 2023 · 1 comment
Open
3 of 5 tasks

Bugs/enhancements for ShOpt runs #5

mcclearyj opened this issue Aug 17, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@mcclearyj
Copy link
Collaborator

mcclearyj commented Aug 17, 2023

I ran into the following issues when running ShOpt for the first time.

Bugs

  • dataPreprocessing.jl assumes VIGNET exists in HDU 2 of a FITS file. This is a very common issue; it would be nice if ShOpt handled this gracefully.
  • reader.jl looks for an extension that doesn't exist in the default truncated mode (3)
  • Star cutouts are off-center in "comfort plot" cutouts produced during run. Is this systematic? It could be minor but if that off-centered star is fed to the pixel grid fitter, that could propagate into the model and cause real problems down the line.

Suggested enhancements

  • It would be nice if one could supply other config files to ShOpt. Half the point of using configuration files is not having to change the same file for different use cases.
  • Not a bug, but the polynomial degree of the analytic (Gaussian) profile fit should be a tunable parameter. At the very least, it should match the pixel grid fit polynomial degree.
@mcclearyj mcclearyj added bug Something isn't working enhancement New feature or request labels Aug 17, 2023
@EdwardBerman
Copy link
Owner

Fixed bugs 1-3, will leave issue open as a reminder to complete enhancements

@EdwardBerman EdwardBerman pinned this issue Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants