Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet Inset #183

Open
nathanacurtis opened this issue Feb 9, 2022 · 3 comments
Open

Tablet Inset #183

nathanacurtis opened this issue Feb 9, 2022 · 3 comments
Assignees
@kevinmpowell
Labels
Defect Ready for Review

Comments

@nathanacurtis
Copy link
Member

The inset at tablet seems too tight. In the comp, it's a more robust 48px.

image
@nathanacurtis
Copy link
Member Author

Interestingly, the CTA and Footer rows seem inset properly at tablet.
image

kevinmpowell pushed a commit that referenced this issue Feb 9, 2022
Modifies #183 - Increase left and right padding at tablet breakpoint
6904b4e
@nathanacurtis
Copy link
Member Author

This issue was partially fixed, but the responsive insetting of the bio name/photo still needs to be normalized with how the other rows are working.
image

@nathanacurtis
Copy link
Member Author

Similarly, with the CTA the inset is 60px which makes it unaligned at certain widths. This would do well to align with row spacing.
image

kevinmpowell pushed a commit that referenced this issue Feb 10, 2022
Modifies #183 - tokenize left and right padding for all rows
3f54354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinmpowell kevinmpowell

Labels
Defect Ready for Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinmpowell @nathanacurtis