Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity not limited for the diff drive controller #148

Open
IDavGal opened this issue Sep 4, 2023 · 2 comments
Open

Velocity not limited for the diff drive controller #148

IDavGal opened this issue Sep 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working humble software

Comments

@IDavGal
Copy link
Contributor

IDavGal commented Sep 4, 2023

Description

The andino_controllers.yaml configuration file specify no limits in the linear/angular velocity. According the motor's description its max velocity is 90 RPM, given the wheel radius this would translate to roughly 0.33 m/s linear vel.
The diff_drive_controller handles both velocities limits separately, so the border case in which linear_vel + angular_vel translates to a higher motor velocity than 90 RPM is not considered by this calculation.

@IDavGal IDavGal added the bug Something isn't working label Sep 4, 2023
@francocipollone francocipollone self-assigned this Sep 4, 2023
@IDavGal
Copy link
Contributor Author

IDavGal commented Oct 4, 2023

There is an open PR in ros2_controllers addressing this issue, although is currently pause.
I'll try to either bump it up or address the issues myself.

@francocipollone
Copy link
Collaborator

There is an open PR in ros2_controllers addressing this issue, although is currently pause. I'll try to either bump it up or address the issues myself.

I should run a local test in the real robot and provide a real-based approximation, wdyt?
My estimation is that we are going to be below 0.5 m/s without effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working humble software
Projects
Status: 📋ToDo
Development

No branches or pull requests

2 participants