Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows world selection from launch file. #36

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Allows world selection from launch file. #36

merged 1 commit into from
Apr 22, 2024

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Apr 22, 2024 •
edited
Loading

🎉 New feature

Summary

  • Adds empty world
  • Allows world selection from launch file.

Test it

ros2 launch andino_gz andino_gz.launch.py world_name:=empty.sdf

ros2 launch andino_gz andino_gz.launch.py world_name:=depot.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)

@francocipollone
Allows multi world seleciton.
e2c8bce 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone merged commit 7c7c388 into humble Apr 22, 2024
2 checks passed
@francocipollone francocipollone deleted the francocipollone/allow_selecting_worlds branch April 22, 2024 20:36
Voldivh
Voldivh reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@Voldivh Voldivh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voldivh Voldivh Voldivh left review comments

@lneumarkt lneumarkt Awaiting requested review from lneumarkt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @Voldivh