Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 bag robot framework API provides duration support when it doesn't exist. #64

Open
serraramiro1 opened this issue Jun 26, 2023 · 1 comment
Labels
bug Something isn't working needs-fix Bug confirmed, need a fix

Comments

@serraramiro1
Copy link
Contributor

serraramiro1 commented Jun 26, 2023

Bug description

When porting to ROS2 we added ros2 bag support, trying to mimic the current ROS1 bag API.
There's a problem with that, and it's that ros2 bag system doesn't have feature parity with ROS1 bag system.

In particular, we provide duration support as part of the

Uses {duration} of {bag}....

keyword, when it doesn't really exist (at least in ROS2 humble), and it actually makes ros2 bag play crash.

I think we should filter out unsupported options from the options map, and warn the user if there're any options that will be ignored.

TODO(Ramiro):

Add repro steps.

@serraramiro1 serraramiro1 added the bug Something isn't working label Jun 26, 2023
@hidmic
Copy link
Collaborator

hidmic commented Jun 28, 2023

Indeed, the feature doesn't exist in Humble. It does in Iron (and Rolling of course). We could verify rosbag2 version and assert it is greater than or equal to 0.17.0 whenever this specific keyword flavor is used in ROS 2.

@hidmic hidmic added the needs-fix Bug confirmed, need a fix label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-fix Bug confirmed, need a fix
Projects
None yet
Development

No branches or pull requests

2 participants