Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update class_c_otaa_ack.ino #182

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update class_c_otaa_ack.ino #182

merged 1 commit into from
Mar 19, 2024

Conversation

damattl
Copy link
Contributor

@damattl damattl commented Mar 13, 2024

  • Added missing call to setDeviceClass()
  • Added comment on CLASS_C flag use

@damattl
Update class_c_otaa_ack.ino
21be9d7 
- Added missing call to setDeviceClass()
- Added comment on _CLASS_C_ flag use

Signed-off-by: Martin Mayer <[email protected]>
REGIOIGER
REGIOIGER approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@REGIOIGER REGIOIGER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because code refactoring is needed to make the C class work as expected, it may be necessary to add back in the loop lora.setDeviceClass(CLASS_C); after executing lora.update();

@REGIOIGER REGIOIGER merged commit 6ce5fe5 into ElectronicCats:master Mar 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@REGIOIGER REGIOIGER REGIOIGER approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damattl @REGIOIGER