Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Improve documentation and use cases #14

Open
3 tasks
praneethd7 opened this issue Sep 24, 2024 · 0 comments
Open
3 tasks

[JOSS Review] Improve documentation and use cases #14

praneethd7 opened this issue Sep 24, 2024 · 0 comments

Comments

@praneethd7
Copy link

praneethd7 commented Sep 24, 2024

Thank you @lauritowal for implementing the changes. I successfully ran the code locally, encountering only a minor issue with numpy>2, which was resolved by downgrading. Consider specifying numpy<2 in pyproject.toml to prevent similar issues.
I'm now reviewing other checklist criteria:

  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems)

While the statement of need is clear, I find it challenging to connect it directly to solving real-world problems. I would recommend the following:

  • Provide examples demonstrating how the tool addresses practical analysis challenges. I am not an expert in this domain but perhaps some examples of where supervised probing techniques fall short and CCS offers advantages would be great.
  • Please clarify the purpose of each file generated by elicit and explain how they can be used in further analysis or applications.
    image

Cross reference: openjournals/joss-reviews#6511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant