Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerization #1

Open
mfojtak opened this issue Mar 8, 2019 · 3 comments
Open

Dockerization #1

mfojtak opened this issue Mar 8, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@mfojtak
Copy link

mfojtak commented Mar 8, 2019

Could it be wrapped into docker container which would have pytest and cromwell and this preinstalled?

@mfojtak mfojtak added the enhancement New feature or request label Mar 8, 2019
@jdidion
Copy link
Collaborator

jdidion commented Aug 7, 2019

Good suggestion. Let's do this after 1.0.

@jdidion jdidion added this to the 1.1 milestone Aug 7, 2019
@jdidion jdidion removed this from the 1.1 milestone Oct 2, 2019
@jdidion
Copy link
Collaborator

jdidion commented Jan 31, 2020

This is non-trivial. For container-based executors (e.g. Cromwell and Miniwdl), Docker needs to run within Docker. This is possible (https://www.docker.com/blog/docker-can-now-run-within-docker/) but requires:

  • Adding -privileged to docker run, which may require modifying the workflow engine
  • Building the Docker image with a few extra dependencies

There's also the question of whether to pre-package all the supported runtimes in the image, or just provide a base image that others can build on by including their preferred runtimes.

@jdidion jdidion added the parked Good idea, won't be implemented any time soon label Feb 18, 2020
@patmagee
Copy link

@jdidion the privileged issue can be solved by adding the current user to the docker group. This is not necessarily trivial, but for people looking for running it this way, they may be willing to do this.

@jdidion jdidion added this to the parked milestone Feb 25, 2020
@jdidion jdidion removed the parked Good idea, won't be implemented any time soon label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants