-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce JSON schema for deny.toml #635
Conversation
deny.template.toml
Outdated
@@ -1,3 +1,5 @@ | |||
#:schema ./deny.schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: this is temporary. Needs to be removed before merging. Schema should be inferred from the schemastore
d472787
to
6af2853
Compare
I went a bit too far with this trying to design a general-purpose tool, but unfortunately, I don't have capacity to finish this work. I'll close this PR for now to prevent it from hanging. I'll leave the stage open for anyone else. |
Status: going through trailing design iterations, there is enough code to start thinking of making it into a separate tool living in a separate repo.
This is the work that is intended to close #632
This PR is not complete yet, it already works nicely, but I want to improve it more. Almost nothing to review. It's just a draft PR that I'll try to finish as soon as I have time.
TODO
The things to do in this PR:
deny.schema.yml
with the remaining shape ofdeny.toml
configsdefault
annotations and enum documentation (not supported in any version)toml_span
TODO after merge
Make a PR to the SchemaStore repo with the entry for
deny.toml
file association.