Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kajiya should not render at a lower resolution on HiDPI screens #86

Open
LoganDark opened this issue Jan 6, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@LoganDark
Copy link

Describe the bug
Kajiya currently explicitly specifies that on HiDPI screens, the viewport will be sized using logical pixels rather than physical pixels.

To Reproduce
Steps to reproduce the behavior:

  1. run any app that uses kajiya

Expected behavior
Rendering should be performed in physical pixels and not upscaled. Upscaling (using DLSS, FSR, etc.) should be an explicit choice and not forced based on the display DPI.

Screenshots
Edges look pretty bad on my 4K display:

image

Additional context
I'm using an old commit of Kajiya for cornell-mcray but AFAICT this 'feature' has remained the same since then.

AFAIK, the main reason to do this is to reduce GPU requirements for weak computers- i.e. the highest-resolution displays, like 4K, are almost always paired with even a lack of any GPU at all- but this way of doing it looks terrible, even compared to simply having a perfect 1080p display in the first place.

@LoganDark LoganDark added the bug Something isn't working label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant