Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support MacOS MPS/CPU #19

Open
Tohrusky opened this issue Jan 7, 2024 · 1 comment
Open

feat: Support MacOS MPS/CPU #19

Tohrusky opened this issue Jan 7, 2024 · 1 comment

Comments

@Tohrusky
Copy link

Tohrusky commented Jan 7, 2024

https://github.com/EmbarkStudios/pdm-plugin-torch/blob/main/pdm-plugin-torch/pdm_plugin_torch/config.py#L43C30-L43C30
7eb50523f90b7f26357d7427b012f43c10e582d377577bb4ef2bca8dd94555bb

There is no way to download the wheel package for MacOS currently, or we can just download it directly from pypi?

@tgolsson
Copy link
Member

Hey!

I'd love a better solution. Before the recent release; we'd actually not use a tag at all for CPU. But that lead to bad behavior in other cases, where we'd end up with GPU-compatible binaries from pypi when it failed to find a suitable CPU variant. So I opted for being more literal, but now Mac is broken (again).

A PR to improve this would be very welcome. I'm wondering whether one could simply use markers to say ...+cpu; os != darwin and ...; os = darwin -- in the CPU case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants