Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support PyTorch Nightly #20

Open
T145 opened this issue Jan 10, 2024 · 3 comments
Open

feat: Support PyTorch Nightly #20

T145 opened this issue Jan 10, 2024 · 3 comments

Comments

@T145
Copy link

T145 commented Jan 10, 2024

Ex: https://download.pytorch.org/whl/nightly/cu121/

@tgolsson
Copy link
Member

Hey!

I'd be happy to support this, and would accept a PR to that effect. Before we get there though, how'd you want to configure it?

@T145
Copy link
Author

T145 commented Jan 15, 2024

Well you already have settings that configure the endpoints, so all you'd need is a way to handle the base URL. Maybe a --nightly arg and enable-nightly config option:

if self.enable_nightly:
            for cuda_version in self.cuda_versions:
                resolves[cuda_version] = (
                    f"https://download.pytorch.org/whl/nightly/{cuda_version}/",
                    f"+{cuda_version}",
                )

It shouldn't be hard to intuit.

@tgolsson
Copy link
Member

Ack, just wanted to see if there was a specific problem you wanted to solve (e.g. "I use torch 2.1 but because of bug X my rocm needs to use nightly").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants