Skip to content

Latest commit

 

History

History
38 lines (29 loc) · 2.08 KB

UPGRADE.md

File metadata and controls

38 lines (29 loc) · 2.08 KB
Raw

UPGRADE FROM 2.x to 3.0

JohnKary\PHPUnit\Listener\SpeedTrapListener subclasses must ensure method signatures match PHPUnit TestListenerDefaultImplementation

SpeedTrapListener was upgraded to support PHPUnit 7.0, which introduced a new trait TestListenerDefaultImplementation containing a few new scalar type hints and void return hints. SpeedTrapListener subclasses overriding any of the below methods will require updating the new method signatures:

Old signature New signature
public function endTest(Test $test, $time) public function endTest(Test $test, float $time): void
public function startTestSuite(TestSuite $suite) public function startTestSuite(TestSuite $suite): void
public function endTestSuite(TestSuite $suite) public function endTestSuite(TestSuite $suite): void

UPGRADE FROM 1.x to 2.0

JohnKary\PHPUnit\Listener\SpeedTrapListener subclasses must implement scalar type hints

SpeedTrapListener was upgraded to support PHP 7 scalar type hints. Any subclass will need to update the overridden function signature:

  • Declare strict types at the top of your subclass: declare(strict_types=1);
  • Update method signatures:
Old signature New signature
protected function isSlow($time, $slowThreshold) protected function isSlow(int $time, int $slowThreshold) : bool
protected function addSlowTest(TestCase $test, $time) protected function addSlowTest(TestCase $test, int $time)
protected function hasSlowTests() protected function hasSlowTests() : bool
protected function toMilliseconds($time) protected function toMilliseconds(float $time) : int
protected function makeLabel(TestCase $test) protected function makeLabel(TestCase $test) : string
protected function getReportLength() protected function getReportLength() : int
protected function getHiddenCount() protected function getHiddenCount() : int
protected function getSlowThreshold(TestCase $test) protected function getSlowThreshold(TestCase $test) : int