Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//chunk & //regen using incorrect seed. #2398

Open
5 tasks done
crumpkatrina opened this issue Sep 24, 2023 · 11 comments
Open
5 tasks done

//chunk & //regen using incorrect seed. #2398

crumpkatrina opened this issue Sep 24, 2023 · 11 comments
Labels
platform:bukkit-spigot-paper Specific to the Bukkit/Spigot/Paper platform status:upstream This issue should be handled upstream from WorldEdit. type:bug Incorrect behavior, not working as intended

Comments

@crumpkatrina
Copy link

WorldEdit Version

Bukkit-Official(7.3.0-SNAPSHOT+6521-bba73e5)

Platform Version

1.20.2 Paper Build 195

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

When selecting a //chunk and //regen 'ing it, the area is not correspondant to the world seed at all.

Expected Behavior

Generate the correct area using the world's seed.

Reproduction Steps

  1. Load server with the above Paper, WorldEdit, WorldGuard versions, as well as latest Multiverse: https://github.com/Multiverse/Multiverse-Core/releases/tag/4.3.12
  2. Use command /mv create testworld normal
  3. Verify seed in game matches the seed in Multiverse config using /seed command
  4. Go to any random chunk and select it with //chunk
  5. Use //regen and notice it regenerates a completely different area.

Anything Else?

Wondering if this has ever been fixed as I've noticed it occurring for a very long time (years) and there continue to be reports about it until this day. Example: #1544 (2020, with latest reply this year in 2023). Would appreciate any help here. CC: @dumptruckman

@crumpkatrina crumpkatrina added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended labels Sep 24, 2023
@me4502
Copy link
Member

me4502 commented Sep 24, 2023

The reply to the issue in 2023 was about someone using an incompatible version of WE (the unrelated error that was brought up)

Only the original poster of that old issue had the issue you're describing. It hasn't been "fixed" as so far only two people have ever reported it, and no one else has ever been able to reproduce it.

We need more information to fix an issue like this, but given on the other issue worldedit was working fine in other worlds it does sound like the seed is just not being given to MC by the world creation system properly

@crumpkatrina
Copy link
Author

It looks like //chunk & //regen is working fine when using on a world generated by Paper.
However, when the world is generated by multiverse, the //chunk & //regen command is not working correctly.

@me4502
Copy link
Member

me4502 commented Sep 27, 2023

WorldEdit gets the seed straight from the world itself, so the only way it could be generating with the wrong seed is if Multiverse is not actually saving the seed to the world correctly

@wizjany
Copy link
Collaborator

wizjany commented Sep 27, 2023

it's possible that the nms we use to retrieve the seed somehow doesn't match up to where it's set in api/paper/whatever. especially since iirc paper has some patch to allow more seed customization, maybe that data is stored elsewhere.

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not been fully confirmed. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale Issue was not confirmed by maintainers label Mar 13, 2024
@crumpkatrina
Copy link
Author

This issue continues to persist.

@stale stale bot removed the status:stale Issue was not confirmed by maintainers label Mar 17, 2024
Copy link

This issue has been automatically marked as stale because it has not been fully confirmed. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the status:stale Issue was not confirmed by maintainers label Jun 22, 2024
@octylFractal
Copy link
Member

This is an issue with Multiverse, not sure if we can fix it.

@octylFractal octylFractal added platform:bukkit-spigot-paper Specific to the Bukkit/Spigot/Paper platform status:upstream This issue should be handled upstream from WorldEdit. and removed status:pending Pending acceptance or closure. status:stale Issue was not confirmed by maintainers labels Jun 22, 2024
@andrewkm
Copy link

andrewkm commented Aug 13, 2024

This is an issue with Multiverse, not sure if we can fix it.

Looks like they responded that it's an issue with WorldEdit:
Multiverse/Multiverse-Core#3035

@dumptruckman
Copy link

dumptruckman commented Aug 13, 2024

We didn't say it was a WorldEdit issue. We're just saying we are just setting the seed from the Bukkit/Spigot/Paper API. If that is wrong, then the issue is likely with the API implementation. One possible alternate explanation could be that the seed is changing after it has been set via the WorldCreator API (which Multiverse does when using /mv create and when loading the worlds on startup). So if you create a world, and then somehow change the seed without restarting the server, and then use //regen, that could explain this mismatch. If that's not it, it seems like it would be the API implementation.

@andrewkm
Copy link

andrewkm commented Aug 13, 2024

We didn't say it was a WorldEdit issue. We're just saying we are just setting the seed from the Bukkit/Spigot/Paper API. If that is wrong, then the issue is likely with the API implementation. One possible alternate explanation could be that the seed is changing after it has been set via the WorldCreator API (which Multiverse does when using /mv create and when loading the worlds on startup). So if you create a world, and then somehow change the seed without restarting the server, and then use //regen, that could explain this mismatch. If that's not it, it seems like it would be the API implementation.

We never change the seed on our server. We simply create the world with MultiVerse and the //regen command doesn't seem to actually regen the chunks from that seed.

Basically the same steps as in the original post above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:bukkit-spigot-paper Specific to the Bukkit/Spigot/Paper platform status:upstream This issue should be handled upstream from WorldEdit. type:bug Incorrect behavior, not working as intended
Projects
None yet
Development

No branches or pull requests

6 participants