Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for event listeners #61

Open
ksIsCute opened this issue May 5, 2022 · 34 comments
Open

add documentation for event listeners #61

ksIsCute opened this issue May 5, 2022 · 34 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@ksIsCute
Copy link
Contributor

ksIsCute commented May 5, 2022

Summary

adding documentation for event listeners and what they listen for

What is the feature request for?

The documentation

The Problem

not annoying enoki when i dont know how to do something because of the lack of documentation on the subject

The Ideal Solution

adding documentation going into a short detail on how to listen for message edits, deletes, or sends and using them to create commands

The Current Solution

annoying enoki

Additional Context

No response

@EnokiUN EnokiUN added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels May 12, 2022
@0x4c756e61
Copy link

I agree, that could be usefull. Because I don't know what are the possible events to use. The events name from the revolt.js page doesn't seems to work.

@EnokiUN
Copy link
Owner

EnokiUN commented May 15, 2022

well atleast untill readthedocs stops being weird or I stop being stupid all the possible events can be found by going to internals/ws.py and searching for dispatch

@0x4c756e61
Copy link

Thanks, that is usefull. Gonna list all of them:

  • onReady : "ready"
  • onMessage : "message"
  • onMessageEdit : "message_update"
  • onmessageDelete : "message_delete"
  • onChannelCreate : "channel_create"
  • oncChannelEdit : "channel_update"
  • onChannelDelete : "channel_delete"
  • onGroupChannelJoin : "group_channel_join"
  • onGroupChannelLeave : "group_channel_leave"
  • onUserStartsTyping : "channel_start_typing"
  • onUserStopsTyping : "channel_stop_typing"
  • onServerEdit : "server_update"
  • onServerDelete : "server_delete"
  • onServerMemberEdit : "server_member_update"
  • onMemberJoin : "member_join"
  • onMemberLeave : "member_leave"
  • onRoleEdit : "server_role_update"
  • onRoleDelete : "server_role_delete"
  • onUserEdit : "user_update"

That's all of it

@ksIsCute
Copy link
Contributor Author

well atleast untill readthedocs stops being weird or I stop being stupid all the possible events can be found by going to internals/ws.py and searching for dispatch

im as clueless as u are with the docs situation at this point it would be in our best interest to kind of factory reset the docs to see why they're failing

@0x4c756e61
Copy link

Could be a solution

@ksIsCute
Copy link
Contributor Author

Could be a solution

best to try it if enoki ever gets online today

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

well atleast untill readthedocs stops being weird or I stop being stupid all the possible events can be found by going to internals/ws.py and searching for dispatch

im as clueless as u are with the docs situation at this point it would be in our best interest to kind of factory reset the docs to see why they're failing

I've tried, I really have

@ksIsCute
Copy link
Contributor Author

well atleast untill readthedocs stops being weird or I stop being stupid all the possible events can be found by going to internals/ws.py and searching for dispatch

im as clueless as u are with the docs situation at this point it would be in our best interest to kind of factory reset the docs to see why they're failing

I've tried, I really have

oh i know you've basically gone insane over the docs problem, at this point would it be in our best interest to just, make it? instead of using readthedocs.io, we can just make a website for it? it seems like it would be a quick fix, or maybe a permanent one? because we can basically have all the same items and more detail if we need it. plus no more rst

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

well atleast untill readthedocs stops being weird or I stop being stupid all the possible events can be found by going to internals/ws.py and searching for dispatch

im as clueless as u are with the docs situation at this point it would be in our best interest to kind of factory reset the docs to see why they're failing

I've tried, I really have

well atleast untill readthedocs stops being weird or I stop being stupid all the possible events can be found by going to internals/ws.py and searching for dispatch

im as clueless as u are with the docs situation at this point it would be in our best interest to kind of factory reset the docs to see why they're failing

I've tried, I really have

oh i know you've basically gone insane over the docs problem, at this point would it be in our best interest to just, make it? instead of using readthedocs.io, we can just make a website for it? it seems like it would be a quick fix, or maybe a permanent one? because we can basically have all the same items and more detail if we need it. plus no more rst

I'm still going to use rst as it builds without any issue, even on my phone.

I've considered using a website but that requires getting a domain and hosting it.

Maybe github pages will bring us salvation?

@ksIsCute
Copy link
Contributor Author

github pages is perfect, because we can just host the pages site in a folder unrelated to voltage, plus if u need css or just help with starting and styling the site :trollface: ask me

@0x4c756e61
Copy link

We could just use markdown, also github as a wiki feature

@ksIsCute
Copy link
Contributor Author

yeah but that limits our options and our ability to style certain objects and to display and optimise

@ksIsCute
Copy link
Contributor Author

we could use markdown, html, and rst, but html and rst are probably our best bet if we want the site to be "bearable"

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

Issue isn't rst, infact it's making life easier. Issue is rtd not working with attributetable for some reason SPECIFICALLY for Voltage.

Maybe it's something stupid I did. idk

@ksIsCute
Copy link
Contributor Author

lets just use gh pages with rst then, because without docs that will drive people away and also "limit" abilities (even thougbh they're a thing, they arent in the documentation, leaving people clueless)

@0x4c756e61
Copy link

0x4c756e61 commented May 17, 2022

We could just setup a github pages running facebook's docusaurus
That's what we did for our language project Swirl

@ksIsCute
Copy link
Contributor Author

good idea

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

Let me try a thing

@ksIsCute
Copy link
Contributor Author

make a new branch and start gh pages in there

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

I started a gh page and uhhhh

css died?

@ksIsCute
Copy link
Contributor Author

wat

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

@ksIsCute
Copy link
Contributor Author

i think we should start from scratch

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

Both you and I know damn well that I no longer have the physical or mental requirements for that especially now that I'm coding on phone

@EnokiUN
Copy link
Owner

EnokiUN commented May 17, 2022

additionally, Leave this for the actual issue at hand, move to the docs discussion

@EnokiUN
Copy link
Owner

EnokiUN commented May 18, 2022

if someone is willing to, go to docs/source/api.rst and add a list of event names and the args they pass

@EnokiUN
Copy link
Owner

EnokiUN commented May 18, 2022

@ksIsCute @0x454d505459

@0x4c756e61
Copy link

I would like to, but I don't know how to use the thing you used to generate docs using rst

@EnokiUN
Copy link
Owner

EnokiUN commented May 18, 2022

to generate the docs you cd into docs and run make html tho rtd does that automatically for every commit

@ksIsCute
Copy link
Contributor Author

🇧🇳

@ksIsCute
Copy link
Contributor Author

if someone is willing to, go to docs/source/api.rst and add a list of event names and the args they pass

got it

@ksIsCute
Copy link
Contributor Author

can i write description for autoclass in https://github.com/EnokiUN/voltage/blob/main/voltage/types/ws.py ?

@ksIsCute
Copy link
Contributor Author

@EnokiUN is this added yet?

@EnokiUN
Copy link
Owner

EnokiUN commented May 26, 2022

@EnokiUN is this added yet?

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants