-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the draggable property to modals #793
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2b87085 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Visit the preview URL for this PR (updated for commit 2b87085): https://react-kitchen-sink-dev--pr793-740-implement-dragga-mvpuq0xf.web.app (expires Mon, 26 Aug 2024 20:45:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
"dependencies": { | ||
"react-draggable": "^4.4.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to dev dependencies
setBounds({ | ||
left: -targetRect.left + uiData.x, | ||
right: clientWidth - (targetRect.right - uiData.x), | ||
top: -targetRect.top + uiData.y, | ||
bottom: clientHeight - (targetRect.bottom - uiData.y), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? Would be nice to have a comment here.
<Draggable | ||
bounds={bounds} | ||
disabled={false} | ||
nodeRef={draggleRef} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you have multiple draggable modals?
Describe your changes
Added a draggable property to modal screens allowing you to move modals around the screen
Screenshots [Optional]
Issue ticket number and link:
Issue #740
Closes #740
Checklist before requesting a review
pnpm changeset add