feat: bump jll version and add opt pass #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/dyngather_opt
branch
from
cf47e4a to
155f469
Compare
|
@wsmoses did something change in Enzyme in the new JLL? https://github.com/EnzymeAD/Reactant.jl/actions/runs/12405818372/job/34633303834?pr=400#step:9:488 |
|
Oh excellent. Yeah I added a better error message for us accidentally segfaulting sometimes due to asking enzyme to return the wrong number of args from an autodiff call |
avik-pal
commented
Dec 19, 2024
| @@ -283,7 +283,7 @@ function overload_autodiff( | |||
| end | |||
| end | |||
| for (i, act) in enumerate(activity) | |||
| if act == enzyme_out || (reverse && (act == enzyme_dup || act == enzyme_dupnoneed)) | |||
There was a problem hiding this comment.
I am not 100% sure if this is the right fix, but it fixes the tests
avik-pal
force-pushed
the
ap/dyngather_opt
branch
from
b50fa0f to
242cfdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.