Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multisymbol issues #53

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix multisymbol issues #53

merged 1 commit into from
Jul 22, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jul 20, 2024

Discovered while looking at macos arm.

@mofeing do you know how to ensure the default is on the release not debug mode [it looks like I default hit debug, which was good for now, but also a problem in the future for users].

Incidentally otherwise the debug one works...

@mofeing
Copy link
Collaborator

mofeing commented Jul 21, 2024

what's the issue with SymbolTable? I mean it to fix it in upstream MLIR.jl

about the default artifact, let me try some stuff

@wsmoses
Copy link
Member Author

wsmoses commented Jul 21, 2024

The finalizer is otherwise broken

@mofeing
Copy link
Collaborator

mofeing commented Jul 21, 2024

Can you tell what does this code returns to you?

using Base.BinaryPlatforms
using Reactant_jll

Reactant_jll.augment_platform!(HostPlatform())

In my case, it correctly sets to opt mode:

julia> Reactant_jll.augment_platform!(HostPlatform())
macOS aarch64 {cuda=none, cxxstring_abi=cxx11, julia_version=1.10.4, libgfortran_version=5.0.0, mode=opt}

@wsmoses wsmoses merged commit 822057c into main Jul 22, 2024
9 of 14 checks passed
@wsmoses wsmoses deleted the multisym branch July 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants