-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move shape information of RArray
to field
#58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally seems reasonable to me -- but would you be able to add the ci for benchmarking so we can test the compile time impact here?
This might be hard because what needs to be measured is only the compilation time of the first execution. Also, how should the info be displayed? Just print the timings? |
@mofeing so it should be fairly easy to do this: https://github.com/EnzymeAD/Enzyme.jl/blob/main/benchmark/benchmarks.jl via https://github.com/EnzymeAD/Enzyme.jl/blob/main/.github/workflows/benchmark_pr.yml which puts automatically a comment in the PR with the overhead change |
@mofeing can you rebase this and see if benchmarking runs? |
c5275a8
to
13b5887
Compare
I'm on it! |
The workflow seems to work but it's BenchmarkTools which is giving me a small headache |
5eccc66
to
15469d7
Compare
15469d7
to
6e1c44d
Compare
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Finally got it working. @wsmoses I just added some basic benchmarks. Don't know if you want some more? |
Discussed in #52
@wsmoses Unfortunately, these commits are tangled with the move to the
Tracing.jl
file.Changes
RArray
will no longer be contained in a type parameter, but in a field.Tracing.jl
file.