-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the new optimization passes #595
Conversation
Test failure https://github.com/EnzymeAD/Reactant.jl/actions/runs/12901169412/job/35972810709#step:9:890
looks new to me |
looks like it already exists: https://github.com/EnzymeAD/Reactant.jl/actions/runs/12896161460/job/35958577153 we should fix/find out where it came from though.... |
The "Not implemented" error is different, that's addressed by Reactant.jl/test/integration/cuda.jl Lines 19 to 23 in 1c42a58
Base.BinaryPlatforms.arch(Base.BinaryPlatforms.HostPlatform()) == "aarch64" &&
|
oh interesting, yeah I didn't look at the actual error message itself. In any case this is still really weird since the error is thrown before the code gets to optimizations here |
I feel like it's more likely to be a test dep version bump that made us sad |
Uhm, julia version changed in the meantime, from v1.11.2 in https://github.com/EnzymeAD/Reactant.jl/actions/runs/12896161460/job/35958577153 to v1.11.3 in https://github.com/EnzymeAD/Reactant.jl/actions/runs/12901169412/job/35972810709#step:9:890. I wonder if they're different manifestations of the same issue mentioned by #543 (comment) (JuliaLang/julia#57077 was merged, but didn't make it for v1.11.3) |
oof, this is worth checking (and asking about backport) |
hm that was merged by 1.11.3? JuliaLang/julia@v1.11.2...v1.11.3 |
Ah, didn't realise it did make it! So that's something different from the Not Implemented error. |
No description provided.