Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the new optimization passes #595

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: add the new optimization passes #595

merged 1 commit into from
Jan 22, 2025

Conversation

avik-pal
Copy link
Collaborator

No description provided.

@giordano
Copy link
Member

Test failure https://github.com/EnzymeAD/Reactant.jl/actions/runs/12901169412/job/35972810709#step:9:890

Square Kernel: Error During Test at /home/runner/work/Reactant.jl/Reactant.jl/test/integration/cuda.jl:26
  Got exception outside of a @test
  InvalidIRError: compiling MethodInstance for Main.var"##CUDA#244".square_kernel!(::ReactantCUDAExt.CuTracedArray{Int64, 1, 1, (64,)}, ::ReactantCUDAExt.CuTracedArray{Int64, 1, 1, (64,)}) resulted in invalid LLVM IR
  Reason: unsupported dynamic function invocation (call to throw_boundserror() @ CUDA ~/.julia/packages/CUDA/1kIOw/src/device/quirks.jl:51)
  Stacktrace:
   [1] #throw_boundserror
     @ ~/.julia/packages/CUDA/1kIOw/src/device/quirks.jl:53
   [2] checkbounds
     @ ./abstractarray.jl:699
   [3] #arrayref
     @ ~/work/Reactant.jl/Reactant.jl/ext/ReactantCUDAExt.jl:62
   [4] getindex
     @ ~/work/Reactant.jl/Reactant.jl/ext/ReactantCUDAExt.jl:151
   [5] square_kernel!
     @ ~/work/Reactant.jl/Reactant.jl/test/integration/cuda.jl:8

looks new to me

@wsmoses
Copy link
Member

wsmoses commented Jan 22, 2025

looks like it already exists: https://github.com/EnzymeAD/Reactant.jl/actions/runs/12896161460/job/35958577153

we should fix/find out where it came from though....

@wsmoses wsmoses merged commit 1c42a58 into main Jan 22, 2025
36 of 39 checks passed
@wsmoses wsmoses deleted the ap/new_opts3 branch January 22, 2025 15:16
@giordano
Copy link
Member

The "Not implemented" error is different, that's addressed by

# GPUCompiler throws "Not implemented" errors on aarch64 before
# <https://github.com/JuliaLang/julia/pull/57077> for some tests.
const skip_tests =
Base.BinaryPlatforms.arch(Base.BinaryPlatforms.HostPlatform()) == "aarch64" &&
VERSION <= v"1.11.3"
but this job was on x864_64 so the condition should be relaxed to remove Base.BinaryPlatforms.arch(Base.BinaryPlatforms.HostPlatform()) == "aarch64" &&

@wsmoses
Copy link
Member

wsmoses commented Jan 22, 2025

oh interesting, yeah I didn't look at the actual error message itself.

In any case this is still really weird since the error is thrown before the code gets to optimizations here

@wsmoses
Copy link
Member

wsmoses commented Jan 22, 2025

I feel like it's more likely to be a test dep version bump that made us sad

@giordano
Copy link
Member

Uhm, julia version changed in the meantime, from v1.11.2 in https://github.com/EnzymeAD/Reactant.jl/actions/runs/12896161460/job/35958577153 to v1.11.3 in https://github.com/EnzymeAD/Reactant.jl/actions/runs/12901169412/job/35972810709#step:9:890. I wonder if they're different manifestations of the same issue mentioned by #543 (comment) (JuliaLang/julia#57077 was merged, but didn't make it for v1.11.3)

@wsmoses
Copy link
Member

wsmoses commented Jan 22, 2025

oof, this is worth checking (and asking about backport)

@wsmoses
Copy link
Member

wsmoses commented Jan 22, 2025

hm that was merged by 1.11.3? JuliaLang/julia@v1.11.2...v1.11.3

@giordano
Copy link
Member

Ah, didn't realise it did make it! So that's something different from the Not Implemented error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants