Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt binary for python bindings #744

Open
mert-kurttutan opened this issue Sep 3, 2024 · 2 comments
Open

Prebuilt binary for python bindings #744

mert-kurttutan opened this issue Sep 3, 2024 · 2 comments
Labels
new feature New feature or request

Comments

@mert-kurttutan
Copy link

What is the current status for providing prebuilt for providing python bindings?

If prebuilt binary is provided, this would be really beneficial in terms of download/compile time of python bindings.
I also came across errors when downloading on my Windows machine due linking issues for intel mkl (its multi threading library, iomp).
(I cannot provide further info on this issue at the moment).
Providing prebuilt binary would also make these issues easier to solve imo.

Also, what do you think about using intel mkl pypi package instead of intel-mkl-src. When using mkl, in my experience, pypi package has been more smooth (especially on windows machines).

I am happy to put work into PR.

@mert-kurttutan mert-kurttutan added the new feature New feature or request label Sep 3, 2024
@mert-kurttutan
Copy link
Author

Hi @EricLBuehler ,
I understand you must be busy. I would very much appreciate an answer as to whether pre built binary is something you are ok with since I can work on this if you are OK with this.
The compilation step is very long, gives error on windows (especially when I share the code with my coworkers) and different from usual from python experience.

@EricLBuehler
Copy link
Owner

Hi @mert-kurttutan! Sorry for not getting back.

I would be happy to have prebuilt python binaries for the various packages. I think it would be very helpful for usability, but my only concern is that I do not have access to Mac or Accelerate hardware locally, so I would not be able to generate binaries for those targets. Perhaps we can use a cloud instance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants