Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexs not working for Command Cooldowns #3847

Closed
Bobcat00 opened this issue Dec 20, 2020 · 3 comments
Closed

Regexs not working for Command Cooldowns #3847

Bobcat00 opened this issue Dec 20, 2020 · 3 comments
Labels
bug: confirmed Confirmed bugs in EssentialsX.

Comments

@Bobcat00
Copy link
Contributor

Information

Full output of /ess version:

Server version: 1.16.4-R0.1-SNAPSHOT git-Spigot-628435a-768d7fc (MC: 1.16.4)
EssentialsX version: 2.18.2.0
LuckPerms version: 5.2.35
Vault version: 1.7.3-b131
EssentialsXChat version: 2.18.2.0
EssentialsXGeoIP version: 2.18.2.0
EssentialsXSpawn version: 2.18.2.0

Server startup log:

[WARN] [Essentials] Command cooldown error: Unclosed group near index 14
^ban([^ip])?( 
[WARN] [Essentials] Command cooldown error: 'MemorySection[path='command-cooldowns.^^ban([^ip])?( ', root='EssentialsConf']' is not a valid cooldown
[WARN] [Essentials] Command cooldown error: Unclosed group near index 14
^ban([^ip])?( 
[WARN] [Essentials] Command cooldown error: 'MemorySection[path='command-cooldowns.^^ban([^ip])?( ', root='EssentialsConf']' is not a valid cooldown

EssentialsX config:

command-cooldowns:
  '^^ban([^ip])?( .*)?': 30

Details

Description:

EssentialsX produces multiple errors when attempting to use the example regex in the Command Cooldowns documentation at https://github.com/EssentialsX/Essentials/wiki/Command-Cooldowns . Any similar regex also results in errors. I can't get any regex ending with ( .)? to work.

Steps to reproduce:

Enter the regex from the documentation for highly technical users, as shown in the above config file excerpt.

Expected behavior:

I expected that EssentialsX would work with the regex given in the official EssentialsX documentation. (It's almost like nobody ever tested this.)

@Bobcat00 Bobcat00 added the bug: unconfirmed Potential bugs that need replicating to verify. label Dec 20, 2020
@triagonal triagonal added bug: confirmed Confirmed bugs in EssentialsX. and removed bug: unconfirmed Potential bugs that need replicating to verify. labels Dec 21, 2020
@triagonal
Copy link
Member

triagonal commented Dec 21, 2020

This is the case for all regular expressions that have a period in them. This is pending an implementation of #3200.

@Bobcat00
Copy link
Contributor Author

My whole reason for going down the regex path was to have a unified cooldown for command aliases, which I see is being handled by #2058. So feel free to close this, or keep it open to keep track of the general regex bug and documentation.

@JRoy
Copy link
Member

JRoy commented Jan 13, 2023

Should be fixed in configurate when using quotes to encase the regex

@JRoy JRoy closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed Confirmed bugs in EssentialsX.
Projects
None yet
Development

No branches or pull requests

3 participants