Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser testing #1

Open
moodysalem opened this issue Sep 14, 2018 · 3 comments
Open

Add browser testing #1

moodysalem opened this issue Sep 14, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@moodysalem
Copy link
Member

moodysalem commented Sep 14, 2018

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
This client needs browser testing - using any browser testing framework, validate that the client can be successfully packaged and ran in the browser. Because it uses isomorphic-ws and cross-fetch, it should be able to run in browser and node environments

@moodysalem moodysalem added enhancement New feature or request help wanted Extra attention is needed labels Sep 14, 2018
@moodysalem
Copy link
Member Author

One issue that might be encountered here is hapijs/joi is not built for the browser and has several node-only dependencies, so one of the steps might be to replace joi with joi-browser in the @ethercast/model dependency

@moodysalem
Copy link
Member Author

@ethercast/model is no longer dependent on joi

@spm32
Copy link

spm32 commented Nov 5, 2018

Hey @moodysalem, saw a bounty request was put up on this issue, are you still interested in having us put some funds towards this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants