Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google AdMob detection fails on new update. #102

Open
MuntashirAkon opened this issue Nov 15, 2020 · 5 comments
Open

Google AdMob detection fails on new update. #102

MuntashirAkon opened this issue Nov 15, 2020 · 5 comments
Labels
tracker Issue about the tracker database

Comments

@MuntashirAkon
Copy link

Previously, these signatures were used for Google Admob detection (there could be others as well but I don't know since I haven't found public VCS):

com.google.ads.|com.google.android.gms.ads.

But recently these have been changed to the following:

com.google.ads.|com.google.android.gms.ads.AdView|com.google.android.gms.ads.AdRequest|com.google.android.gms.ads.mediation|com.google.android.gms.ads.doubleclick

Which means classes such as com.google.android.gms.ads.AdActivity are skipped from scanning.

Previous static scan listed 290 classes for an app called Battery Bar Free and how it lists only 61.

@MuntashirAkon
Copy link
Author

Also, com.google.unity.ads. seems to be missing.

@pnu-s
Copy link
Member

pnu-s commented Dec 16, 2020

Hi @MuntashirAkon

We indeed restricted the list of signatures matching for this tracker because we had some false positives. I'll investigate the 2 new signatures you mentioned, thanks!

@pnu-s pnu-s added the tracker Issue about the tracker database label Dec 16, 2020
@MuntashirAkon
Copy link
Author

We indeed restricted the list of signatures matching for this tracker because we had some false positives.

What were the false-positives, could you, perhaps, share a link to the discussion? I've included com.google.android.gms.ads.AdActivity as an example, there are other classes that are missing there. Since Exodus only does static scans which isn't really perfect, wouldn't it be the best to leave com.google.android.gms.ads. as is instead of adding all the true positive classes?

@pnu-s
Copy link
Member

pnu-s commented Jan 7, 2021

What were the false-positives, could you, perhaps, share a link to the discussion? I've included com.google.android.gms.ads.AdActivity as an example, there are other classes that are missing there.

I think they were several discussions, but the only one I could find is this one: Exodus-Privacy/exodus#390

@MuntashirAkon
Copy link
Author

I think they were several discussions, but the only one I could find is this one: Exodus-Privacy/exodus#390

Thanks. I'll further investigate on that matter to separate all the useful classes between Firebase Analytics and AdMob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracker Issue about the tracker database
Development

No branches or pull requests

2 participants