Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize regexps for code signatures #78

Open
eighthave opened this issue Jul 13, 2020 · 4 comments
Open

standardize regexps for code signatures #78

eighthave opened this issue Jul 13, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@eighthave
Copy link
Contributor

eighthave commented Jul 13, 2020

Right now the code signature regexp are basically all words separated by . Since . matches anything, this could lead to false positives, e.g. the regexp com.here would match com.here and comehere. Code signature printing methods generally use either . or / as the separator, so using [/.] would be the most accurate. Otherwise if there are other potential chars used as separators, using \W ("non-word chars") would be better than .

@pnu-s pnu-s added the enhancement New feature or request label Jul 13, 2020
@eighthave
Copy link
Contributor Author

@pnu-s I think you mentioned you were going to do a mass edit on this directly in the database. Using [/.] would be best IMHO.

@pnu-s
Copy link
Member

pnu-s commented Oct 3, 2020

@eighthave You're right, we discussed this but I did not take the time to do so yet.

I need to make sure this won't break anything by making a couple of tests but I agree with your proposal.

@pnu-s pnu-s self-assigned this Oct 3, 2020
@jawz101
Copy link

jawz101 commented Oct 28, 2020

yes please. I never know how thorough of a regex expression to use.


ads.advertising.com
sdk.advertising.com

^.*.advertising.com$

or just a string search of the advertising domain so it grabs all advertising.TLD? I guess I just leave it to you all to change and we just give you realworld examples in the box

@eighthave
Copy link
Contributor Author

eighthave commented Oct 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants