[$1000] Cursor appears zoom cursor for a moment and changes to normal cursor when opening profile pic from details page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app in mac chrome/windows chrome
2. Open report that has profile pic set
3. Click on user profile image
4. In details page, again click on profile image

Expected Result:

App should display image with normal cursor

From issue reporter:

The cursor should be generic when we click on attachment and it should display as zoom cursor only when we hover on the image part in the attachment preview. Mac safari does this task right, you can use that as reference point.

Actual Result:

App first displays image with zoom cursor and after some time changes the cursor back to normal cursor

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• MacOS / Desktop

Version Number: 1.2.87-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1731.mp4

cursor.fluctate.issue.mov

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679128979658119

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c8aa50007c703f7
• Upwork Job ID: 1640658402418044928
• Last Price Increase: 2023-04-04

[MelvinBot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Back from OOO, reviewing

[greg-schroeder]

@dhanashree-sawant @kavimuru - I'm a little unclear on the expected behavior here. When is that zoom icon supposed to show up? Is it possible that it should be showing up and remaining when mousing over the photo? Or should it just be the generic cursor icon at all times?

Can you please clarify?

[dhanashree-sawant]

Hi @greg-schroeder, cursor should be generic when we click on attachment and it should display as zoom cursor only when we hover on the image part in the attachment preview. Mac safari does this task right, you can use that as reference point.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~019c8aa50007c703f7

[greg-schroeder]

Okay, got it! Updated OP with that clarification. Applied external

[MelvinBot]

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[MelvinBot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[PrashantMangukiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicked profile pic, cursor appears zoom cursor for a moment and changes to normal cursor when opening profile pic from details page.

What is the root cause of that problem?

When we click profile image it will open AttachmentModel >> AttachmentView >> ImageView.
So within <ImageView> it will show image with Pressable as shown below, we can see at line 279 it is calling StyleUtils.getZoomCursorStyle() to get cursor style.

App/src/components/ImageView/index.js

Lines 275 to 282 in c803b5e

	<Pressable
	style={{
	...StyleUtils.getZoomSizingStyle(this.state.isZoomed, this.state.imgWidth, this.state.imgHeight, this.state.zoomScale,
	this.state.containerHeight, this.state.containerWidth),
	...StyleUtils.getZoomCursorStyle(this.state.isZoomed, this.state.isDragging),
	...this.state.isZoomed && this.state.zoomScale >= 1 ? styles.pRelative : styles.pAbsolute,
	...styles.flex1,
	}}

Here is the code for getZoomCursorStyle() function

App/src/styles/StyleUtils.js

Lines 180 to 188 in c803b5e

	function getZoomCursorStyle(isZoomed, isDragging) {
	if (!isZoomed) {
	return {cursor: 'zoom-in'};
	}
	return {
	cursor: isDragging ? 'grabbing' : 'zoom-out',
	};
	}

This function receive two params isZoomed and isDragging so based on that it will return cursor style. Here function does not have any info about image width and height.

So actually what happen here, when <ImageView> load it will calculate image width and height. Initial state value for isZoomed is false, and imgHeight and imgWidth is zero. So during that time getZoomCursorStyle() will return cursor: 'zoom-in' at line 182 based on the isZoomed false value. Because this function does not know either image have some dimension (width and height) or not.

So during that fraction of time (i.e. until image dimension decided) it will show zoom-in cursor. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

Within src/components/ImageView/index.js we have to pass imageWidth and imageHeight to getZoomCursorStyle() function as shown below:

 <Pressable 
     style={{ 
        ...
        // ...StyleUtils.getZoomCursorStyle(this.state.isZoomed, this.state.isDragging),    // *** OLD CODE ***
        ...StyleUtils.getZoomCursorStyle(this.state.isZoomed, this.state.isDragging, this.state.imgWidth, this.state.imgHeight),   // *** UPDATED CODE ***
        ...
     }} 

Within src/styles/StyleUtils.js update getZoomCursorStyle() function as shown below.
i.e. add imgWidth and imgHeight params to function and put if condition as shown below. So if image dimension zero it will return default cursor.

function getZoomCursorStyle(isZoomed, isDragging, imgWidth, imgHeight) {
    // Add below if condition
    if (imgWidth === 0 || imgHeight === 0) {
        return {cursor: 'default'};
    }

    if (!isZoomed) {
        return {cursor: 'zoom-in'};
    }

    return {
        cursor: isDragging ? 'grabbing' : 'zoom-out',
    };
}

So this will solve the problem, we can see the results.

What alternative solutions did you explore? (Optional)

None

Result

Image-open-cursor.mov

[grgia]

@aimane-chnaif could you take a look at this proposal if you get a chance?

[aimane-chnaif]

I confirmed that cursor issue was gone in v1.2.89-0 after #15663 merged.
Instead, it introduced another flicker issue (should be regression). As seen in video, image zoomed in for a brief moment:

bug.mov

@grgia should we handle this issue here?

[MelvinBot]

@greg-schroeder @grgia @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@greg-schroeder, @grgia, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[grgia]

@aimane-chnaif let's make sure there's a separate issue for the flicker effect. We can then close out this issue.

[aimane-chnaif]

ok, let's close. I just found out that issue - #16528 (comment)

[dhanashree-sawant]

Hi @grgia , @aimane-chnaif if closed, will it be eligible for reporting bonus?

[grgia]

@dhanashree-sawant

From the Contributing Guide:

If the bug is fixed by a PR that is not associated with your bug report, then you will not be eligible for the corresponding compensation unless you can find the PR that fixed it and prove your bug report came first.

It looks like the issue that the PR fixed links back to an issue from 2022, so I don't believe this is eligible for the reporting bonus unless you can prove that your bug report came first.

cc @greg-schroeder if you have any input on this

[dhanashree-sawant]

Hi @grgia , sounds fair, thanks for the reply

[greg-schroeder]

You are correct @grgia

[greg-schroeder]

Closing per discussion above