Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Hold - App returns to Hold - reason page when tapping on back button after holding expense #45446

Closed
3 of 6 tasks
m-natarajan opened this issue Jul 16, 2024 · 9 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


issue found when validating #44880
Version Number: 9.0.7-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to workspace chat that has no unsettled expense.
  3. Submit an expense.
  4. Tap on the expense preview to go to expense report.
  5. Tap on the report header.
  6. Tap Hold.
  7. Enter a reason and save it.
  8. Tap on the back button on transaction thread.

Expected Result:

App will return to the previous page (main chat or expense report).

Actual Result:

App returns to Hold - reason page when tapping on back button after holding an expense.

NOTE: This issue only happens when there is only one expense in the combined report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6543364_1721089776683.RPReplay_Final1721089421.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@dominictb
Copy link
Contributor

The same RCA with #45443.

@hayata-suenaga
Copy link
Contributor

looks like a PR was created and the issue is tracked here

removing the deploy blocker from this issue

@hayata-suenaga hayata-suenaga added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Jul 16, 2024
@joekaufmanexpensify
Copy link
Contributor

@hayata-suenaga if this issue has the same RCA as the other one and a PR is up, should we just close this one?

@joekaufmanexpensify
Copy link
Contributor

Bump @hayata-suenaga for when you have a sec

@hayata-suenaga
Copy link
Contributor

yes I think we can close this one 😄

@joekaufmanexpensify
Copy link
Contributor

Sweet. TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants